Skip to content

CONSOLE-4492,CONSOLE-4514: Align spacing of page elements with PatternFly and remove border after PageHeading#14875

Merged
openshift-merge-bot[bot] merged 14 commits intoopenshift:mainfrom
rhamilto:CONSOLE-4514
Mar 30, 2025
Merged

CONSOLE-4492,CONSOLE-4514: Align spacing of page elements with PatternFly and remove border after PageHeading#14875
openshift-merge-bot[bot] merged 14 commits intoopenshift:mainfrom
rhamilto:CONSOLE-4514

Conversation

@rhamilto
Copy link
Member

@rhamilto rhamilto commented Mar 13, 2025 •
edited
Loading

Includes changes from #14805, which will be closed so we can get all the changes in in light of CI flakiness.

After

localhost_9000_k8s_all-namespaces_import
localhost_9000_k8s_all-namespaces_import (1)
localhost_9000_k8s_all-namespaces_import (2)
localhost_9000_k8s_all-namespaces_import (3)
localhost_9000_k8s_all-namespaces_import (4)

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 13, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 13, 2025 •
edited by openshift-ci bot
Loading

@rhamilto: This pull request references CONSOLE-4514 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

Details

In response to this:

Includes changes from #14805, which should merge first.

After

localhost_9000_k8s_all-namespaces_import
localhost_9000_k8s_all-namespaces_import (1)
localhost_9000_k8s_all-namespaces_import (2)
localhost_9000_k8s_all-namespaces_import (3)
localhost_9000_k8s_all-namespaces_import (4)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from bipuladh and cajieh March 13, 2025 18:01
@openshift-ci openshift-ci bot added component/core Related to console core functionality component/dashboard Related to dashboard approved Indicates a PR has been approved by an approver from all required OWNERS files. component/dev-console Related to dev-console component/gitops Related to gitops-plugin component/helm Related to helm-plugin labels Mar 13, 2025
@rhamilto
Copy link
Member Author

rhamilto commented Mar 13, 2025

/assign @logonoff
/assign @yapei

Follow-on to previously approved story, so assigning approvals:
/label px-approved
/label docs-approved

@openshift-ci openshift-ci bot added the component/knative Related to knative-plugin label Mar 13, 2025
@openshift-ci openshift-ci bot added component/lso Related to local-storage-operator-plugin component/metal3 Related to metal3-plugin labels Mar 13, 2025
@rhamilto
Copy link
Member Author

rhamilto commented Mar 13, 2025

/hold for #14805 to merge first

@openshift-ci openshift-ci bot added component/monitoring Related to monitoring px-approved Signifies that Product Support has signed off on this PR component/olm Related to OLM docs-approved Signifies that Docs has signed off on this PR do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. component/pipelines Related to pipelines-plugin component/sdk Related to console-plugin-sdk component/shared Related to console-shared component/topology Related to topology labels Mar 13, 2025
logonoff
logonoff approved these changes Mar 13, 2025
View reviewed changes
Copy link
Member

@logonoff logonoff left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes look good to me. I'll give lgtm once #14805 merges as I anticipate that a few more rebases will probably still be needed lol

@XiyunZhao
Copy link
Contributor

XiyunZhao commented Mar 14, 2025

I have checked all regular pages that include the Tab menu bar, the border has been successfully removed, and no omissions were found
/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Mar 14, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 14, 2025 •
edited by openshift-ci bot
Loading

@rhamilto: This pull request references CONSOLE-4514 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

Details

In response to this:

Includes changes from #14805, which should merge first.

After

localhost_9000_k8s_all-namespaces_import
localhost_9000_k8s_all-namespaces_import (1)
localhost_9000_k8s_all-namespaces_import (2)
localhost_9000_k8s_all-namespaces_import (3)
localhost_9000_k8s_all-namespaces_import (4)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 29, 2025
@rhamilto
Copy link
Member Author

rhamilto commented Mar 29, 2025

Added potential Cypress upgrade fix and rebased. If the Cypress fix works, we'll want a follow-on story to remove injectDocumentDomain from the Cypress configs as that option will eventually be removed. See https://docs.cypress.io/app/references/changelog#14-0-0

@logonoff
Copy link
Member

logonoff commented Mar 29, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 29, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 29, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: logonoff, rhamilto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rhamilto
Copy link
Member Author

rhamilto commented Mar 29, 2025

/lgtm

Thank you, @logonoff!

@rhamilto
Copy link
Member Author

rhamilto commented Mar 29, 2025 •
edited
Loading

Added potential Cypress upgrade fix and rebased. If the Cypress fix works, we'll want a follow-on story to remove injectDocumentDomain from the Cypress configs as that option will eventually be removed. See https://docs.cypress.io/app/references/changelog#14-0-0

https://issues.redhat.com/browse/CONSOLE-4537

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 29, 2025

/retest-required

Remaining retests: 0 against base HEAD 3bc8cb9 and 2 for PR HEAD 1650571 in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 30, 2025

@rhamilto: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit a6b4f71 into openshift:main Mar 30, 2025
8 checks passed
@logonoff
Copy link
Member

logonoff commented Mar 30, 2025

/honk

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 30, 2025

@logonoff:
goose image

Details

In response to this:

/honk

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-bot
Copy link
Contributor

openshift-bot commented Mar 30, 2025

[ART PR BUILD NOTIFIER]

Distgit: openshift-enterprise-console
This PR has been included in build openshift-enterprise-console-container-v4.20.0-202503300149.p0.ga6b4f71.assembly.stream.el9.
All builds following this will include this PR.

@rhamilto rhamilto deleted the CONSOLE-4514 branch March 30, 2025 11:25
@adamviktora adamviktora mentioned this pull request Apr 1, 2025
Merged
This was referenced Apr 11, 2025
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bipuladh bipuladh Awaiting requested review from bipuladh

@cajieh cajieh Awaiting requested review from cajieh

1 more reviewer

@logonoff logonoff logonoff approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@yapei yapei

@logonoff logonoff

Labels

acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality component/dashboard Related to dashboard component/dev-console Related to dev-console component/gitops Related to gitops-plugin component/helm Related to helm-plugin component/knative Related to knative-plugin component/lso Related to local-storage-operator-plugin component/metal3 Related to metal3-plugin component/monitoring Related to monitoring component/olm Related to OLM component/pipelines Related to pipelines-plugin component/sdk Related to console-plugin-sdk component/shared Related to console-shared component/topology Related to topology docs-approved Signifies that Docs has signed off on this PR jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. kind/cypress Related to Cypress e2e integration testing lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@rhamilto @openshift-ci-robot @XiyunZhao @logonoff @openshift-bot @yapei @openshift-merge-robot